Skip to content

Conversation

realstealthninja
Copy link
Collaborator

@realstealthninja realstealthninja commented Oct 4, 2024

Description of Change

Testing

This pr enables testing of the algorithms in the repository
before we get to the stage of running tests on a CI. We will need to remove all
other code from every main function so that the only remaining code is a call to the test function.

for now this draft pull request shows how easy it is to enable testing.
adding it to the awesome CI will be as easy as adding
make test to a test step.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Copy link
Contributor

github-actions bot commented Nov 4, 2024

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Author has not responded to the comments for over 2 weeks label Nov 4, 2024
@realstealthninja realstealthninja added dont-close This issue/pull request shouldn't be closed and removed stale Author has not responded to the comments for over 2 weeks labels Nov 4, 2024
vil02 added a commit to vil02/C-Plus-Plus that referenced this pull request Sep 26, 2025
realstealthninja added a commit that referenced this pull request Sep 27, 2025
Helps with #2753

Co-authored-by: realstealthninja <[email protected]>
@realstealthninja realstealthninja marked this pull request as ready for review September 27, 2025 06:47
@realstealthninja
Copy link
Collaborator Author

@vil02 Do you think we should wait until all test cases pass, i.e. fix all the files?

@vil02
Copy link
Member

vil02 commented Sep 27, 2025

@vil02 Do you think we should wait until all test cases pass, i.e. fix all the files?

In short: yes.

But the optimistic thing is that maybe one can work directory by directory, i.e. select one, let's say math, make all of the files there runnable (they cannot contain any std::cin, scanf or any other user input), modify the corresponding CMakelist.txt file to treat all of the cpp file as tests and merge this change.

Doing all at once is way too much.

vil02 added a commit to vil02/C-Plus-Plus that referenced this pull request Sep 29, 2025
realstealthninja added a commit to realstealthninja/C-Plus-Plus that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-close This issue/pull request shouldn't be closed testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants